rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

feat:[shell] Add FINSH_SEM_NAME macro definition for unified semaphore naming

Open wdfk-prog opened this issue 3 months ago • 4 comments

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

  • FINSH_SEM 可能需要在其他地方被寻找,进而进行控制或删除.例如qboot中重新接管了控制台的操作
  • 由于finsh 信号量是无法被外面调用,所以将finsh 信号量的名称进行宏定义,方便寻找

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [ ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [ ] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [ ] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [ ] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [ ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [ ] 代码是高质量的 Code in this PR is of high quality
  • [ ] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [ ] 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

wdfk-prog avatar Sep 09 '25 05:09 wdfk-prog

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)
  • components/finsh/shell.c
  • components/finsh/shell.h

📊 Current Review Status (Last Updated: 2025-09-11 08:22 CST)

  • Maihuanyi Reviewed On 2025-09-10 15:59 CST

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态 Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认 PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。 ℹ️ Refresh CI status operation requires repository Write permission.

github-actions[bot] avatar Sep 09 '25 05:09 github-actions[bot]

LGTM

Maihuanyi avatar Sep 10 '25 07:09 Maihuanyi

此提交包含#10678 的内容,注意改动内容与提交内容的对应

meng-plus avatar Sep 10 '25 14:09 meng-plus

此提交包含#10678 的内容,注意改动内容与提交内容的对应

٩( 'ω' )و get!

wdfk-prog avatar Sep 11 '25 00:09 wdfk-prog