rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard
verified publisher icon RT-Thread

Resolve the issue of system crashes caused by using mutex locks for memory allocation when a thread polls multiple file descriptors

Open zhj18115188906 opened this issue 4 months ago • 3 comments

…emory allocation when a thread polls multiple file descriptors

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

因为内存分配使用什么锁进行临界区保护很重要，因此对于实时系统如果使用“关中断”或者“禁止调度”这两种措施，对于实时系统是不可接受的，项目中使用这两种临界保护，实时性受到很大影响，特别在堆使用片外sdram时，实时性受影响巨大。所以这两种措施虽然可以解决系统不崩溃问题，但是已经偏离了实时系统的本意。故，只能使用互斥锁，不影响实时线程的调度。但是使用互斥锁的情况下，在某线程使用多fd同时poll时存在致命的bug，系统会死机。早期的rt-thread版本使用的是信号量，同样存在此问题。

你的解决方案是什么 (what is your solution)

对于在某线程使用多个fd同时poll，且内存分配使用互斥类锁时，建议修改poll的机制，不要使用calloc分配node，否则free时会触发bug。

请提供验证的bsp和config (provide the config and bsp)

bsp和config用什么都没问题，系统中最好3个线程以上，线程1最好使用网络，因为这样就有一个监听的fd和一个连接客户端的fd。另外两个线程应存在动态分配内存。

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [ x] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [x ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [ x] 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [x ] 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [ x] 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [x ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [x ] 代码是高质量的 Code in this PR is of high quality
  • [x] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [x ] 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

zhj18115188906 avatar Aug 09 '25 02:08 zhj18115188906

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 09 '25 02:08 CLAassistant

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/libc/posix/io/poll/poll.c

🏷️ Tag: components_libc

Reviewers: @GorrayLi @mysterywolf

Changed Files (Click to expand)
  • components/libc/posix/io/poll/poll.c

📊 Current Review Status (Last Updated: 2025-08-09 10:53 CST)

  • ⌛ @GorrayLi Pending Review
  • ⌛ @Maihuanyi Pending Review
  • ⌛ @mysterywolf Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态 Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认 PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。 ℹ️ Refresh CI status operation requires repository Write permission.

github-actions[bot] avatar Aug 09 '25 02:08 github-actions[bot]

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/libc/posix/io/poll/poll.c

🏷️ Tag: components_libc

Reviewers: @GorrayLi @mysterywolf

Changed Files (Click to expand)
  • components/libc/posix/io/poll/poll.c

📊 Current Review Status (Last Updated: 2025-09-29 09:44 CST)

  • ⌛ @GorrayLi Pending Review
  • ⌛ @Maihuanyi Pending Review
  • ⌛ @mysterywolf Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态 Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认 PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。 ℹ️ Refresh CI status operation requires repository Write permission.

github-actions[bot] avatar Sep 29 '25 01:09 github-actions[bot]