rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

fix(klibc\kstdio): vsnprinf size_t can not exceed INT32_MAX, don't u…

Open liuyangzys opened this issue 8 months ago • 5 comments

…se (rt_size_t -1)

拉取/合并请求描述:(PR description)

[

开启RT_KLIBC_USING_LIBC_VSNPRINTF后,rt_vsprintf 执行异常。排查原因为 vsnprinf 的 size 参数不能超过 INT32 最大值。

编译器

arm-none-eabi-gcc v10.3.1

mcu

stm32h7xx

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [x] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [x] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [x] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [x] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [x] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [x] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [x] 代码是高质量的 Code in this PR is of high quality
  • [x] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [x] 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

liuyangzys avatar Apr 21 '25 07:04 liuyangzys

这个问题完全可以复现的,编译器直接就会警告。所有相关的rt_vsprintf数都会执行失败返回-1。感觉应该尽快修复

liuyangzys avatar Apr 22 '25 17:04 liuyangzys

rt_vsprintf

可否具体讲讲复现方法吗?这边ci检测看起来没有报warning。 https://github.com/RT-Thread/rt-thread/actions/runs/14599436945/job/40953639237

supperthomas avatar Apr 23 '25 01:04 supperthomas

rt_vsprintf

可否具体讲讲复现方法吗?这边ci检测看起来没有报warning。 https://github.com/RT-Thread/rt-thread/actions/runs/14599436945/job/40953639237

或者也可以把报错截图发出来

supperthomas avatar Apr 23 '25 01:04 supperthomas

rt_vsprintf

可否具体讲讲复现方法吗?这边ci检测看起来没有报warning。 https://github.com/RT-Thread/rt-thread/actions/runs/14599436945/job/40953639237

或者也可以把报错截图发出来

image

需要使能使用 libc的 vsnprintf

liuyangzys avatar May 02 '25 12:05 liuyangzys

lgtm

lianux-mm avatar Jun 14 '25 02:06 lianux-mm