Folo icon indicating copy to clipboard operation
Folo copied to clipboard

fix: set `MODAL_STACK_Z_INDEX` to `10000`

Open xhuajin opened this issue 1 year ago • 2 comments

Description

When using the desktop version (Windows 10), I noticed that when the ‘Trending’ section is opened, the ‘Minimize, Reduce, Close’ buttons in the top right corner overlap the ‘Trending’ modal, obscuring about a third of the ‘Trending’ close button.

bug screenshot: image

Upon inspection, it was found that the z-index of the three buttons in the top right corner was set to 9999, whereas the z-index of the ‘Trending’ modal was only 1001. After attempting to change the z-index of the three buttons from 9999 to 1000, everything appeared to function normally. However, to minimize the impact, this PR opts to resolve the issue by increasing the z-index of the modal from 1001 to 10000.

Screenshot after repair: image

xhuajin avatar Oct 15 '24 16:10 xhuajin

@xhuajin is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 15 '24 16:10 vercel[bot]

Simply increasing the z-index value isn't the best solution. It's generally expected for the application's action buttons to remain on the top layer.

lawvs avatar Oct 15 '24 18:10 lawvs

This implementation doesn't make sense, you should adjust the boundaries of the modal instead of the Z-index.

Innei avatar Oct 16 '24 04:10 Innei

According to your suggestion, I remove the previous method of modifying z-index and add 'top: ${ElECTRON_CUSTOM_TITLEBAR_HEIGHT}px' to solve this problem.

Now the trending modal will look like: image

xhuajin avatar Oct 16 '24 08:10 xhuajin

Sorry, I just fixed this, there is a built-in css atom class named safe-inset-top-4, you can use it.

Innei avatar Oct 16 '24 12:10 Innei

Got it. Thanks for your reply

xhuajin avatar Oct 16 '24 13:10 xhuajin