Folo icon indicating copy to clipboard operation
Folo copied to clipboard

v0.0.1-alpha.19 的在浏览器打开快捷键失效

Open Sunsh4j opened this issue 1 year ago • 12 comments

Describe the bug

如题

Feed Info

Reproduction Video

No response

App Type

Electron / App

Version

v0.0.1-alpha.19

Operating System

Windows 10

Browser Info

chrome

Validations

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.

Contributions

  • [ ] I am willing to submit a PR to fix this issue
  • [ ] I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

Sunsh4j avatar Oct 06 '24 08:10 Sunsh4j

@lawvs Since the last time we replaced the open in browser logic with view content source, the shortcut is not working according to the current shortcut implementation logic. The reason is that the entry action is not bound. Do you have any ideas for this?

Innei avatar Oct 07 '24 16:10 Innei

In https://github.com/RSSNext/Follow/pull/655, the "Open in New Tab" action in the toolbar has been replaced with "View Source Content," causing this issue. I will try to fix it after discussing the new shortcut design.

lawvs avatar Oct 07 '24 17:10 lawvs

Hello, I would like to ask for your help again. In the Follow key combinations, there is a symbol between the keys, but I haven’t been able to figure out which key it represents on Windows. As a result, I’m unable to trigger the entire key combination. 20241008_082538_453_copy

Sunsh4j avatar Oct 08 '24 00:10 Sunsh4j

On windows, the meta key mapping should point to ctrl, this is a design error, I'll fix it later.

Innei avatar Oct 08 '24 05:10 Innei

Thank you for your response.

Additionally, could you add a shortcut key for the newly introduced wide mode, similar to the existing shortcut key for the sidebar, to easily toggle it on and off? The wide mode is a fantastic feature, but constantly moving the mouse to click is a bit inconvenient.

Having enough shortcut keys to control the software makes the experience incredibly satisfying. I hope you will consider this suggestion.

Sunsh4j avatar Oct 08 '24 06:10 Sunsh4j

When wide mode is enabled and the appearance is set to dark mode, there is an issue when clicking on an article.

image

Sunsh4j avatar Oct 08 '24 16:10 Sunsh4j

When wide mode is enabled and the appearance is set to dark mode, there is an issue when clicking on an article.

image

This bug is already fixed in nightly version

Innei avatar Oct 08 '24 16:10 Innei

Received.

Could you please consider adding a shortcut key for "wide mode"? It would be greatly appreciated.

Sunsh4j avatar Oct 09 '24 00:10 Sunsh4j

After updating Follow to the latest version, the shortcut to quickly open the browser still doesn’t work.

Sunsh4j avatar Oct 12 '24 07:10 Sunsh4j

+1 0.0.1-nightly.20241016 Mac 版本,依旧无效

xuzhe1224 avatar Oct 17 '24 06:10 xuzhe1224

@lawvs 👀

Innei avatar Oct 17 '24 07:10 Innei

Mac 客户端 依旧无效

Environment

App Version: 0.1.1-beta.1 OS: macOS User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Follow/0.1.1-beta.1 Chrome/130.0.6723.44 Electron/33.0.0 Safari/537.36 Env: electron Browser: Chrome

hikerpig avatar Nov 01 '24 05:11 hikerpig

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Mac client still doesn’t work

Environment

App Version: 0.1.1-beta.1 OS: macOS User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS Env: electron Browser: Chrome

github-actions[bot] avatar Nov 01 '24 05:11 github-actions[bot]

Fixed in https://github.com/RSSNext/Follow/pull/1566

lawvs avatar Nov 19 '24 06:11 lawvs