Folo icon indicating copy to clipboard operation
Folo copied to clipboard

Image is grey in Pictures View

Open cesaryuan opened this issue 1 year ago • 3 comments

Describe the bug

As shown in the video, in picture view, when you click on the details page of an item, the picture cannot be displayed and is always gray.

Feed Info

rsshub://voronoiapp/latest

Reproduction Video

https://github.com/user-attachments/assets/328d1a27-b57f-4d70-a17c-a8ec2baeb763

App Type

Web

Version

Environment App Version: 0.0.1-alpha.19 OS: Windows User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36 Env: web Browser: Chrome

Operating System

Windows 11

Browser Info

No response

Validations

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.

Contributions

  • [x] I am willing to submit a PR to fix this issue
  • [ ] I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

cesaryuan avatar Oct 05 '24 11:10 cesaryuan

This bug is introduced in 14c7028347b22eb1cf768d5c3a4c20ffe9497b93, which set the img maxWidth and maxHeight. But the media's width and height is zero (I don't know why it is 0, this is the result returned by /entries api)

image

Update: After revert this commit, the bug disappeared.

cesaryuan avatar Oct 05 '24 12:10 cesaryuan

@hyoban Follow up this plz

Innei avatar Oct 05 '24 14:10 Innei