Folo icon indicating copy to clipboard operation
Folo copied to clipboard

fix: alignment of the title style at the top of the right content page

Open cuikaipeng opened this issue 1 year ago • 1 comments

the type title at the top of the right content page is misaligned across different subscription types. in the "EntryListHeader" component, an array named "titleStyleBasedView" is defined to configure the padding for various subscription types. I think this is unnecessary. I attempted to remove it and instead apply a consistent padding value of "pl-7". iShot_2024-10-02_22 55 00

cuikaipeng avatar Oct 02 '24 15:10 cuikaipeng

@cuikaipeng is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 02 '24 15:10 vercel[bot]

Why?

Innei avatar Oct 03 '24 03:10 Innei

Why?

I noticed that the text positions of the titles [Articles] [Social Media] [Audios] [Notifications], were not aligned, so, I submitted this pull request. or is this intentional design?

cuikaipeng avatar Oct 03 '24 05:10 cuikaipeng

From a design perspective, we need to get the elements on a baseline vertically.

CleanShot 2024-10-03 at 4  23 43@2x CleanShot 2024-10-03 at 4  24 25@2x

Innei avatar Oct 03 '24 08:10 Innei

Got it, sorry for wasting your time reading this PR now we can close this PR

cuikaipeng avatar Oct 03 '24 08:10 cuikaipeng