Folo feat: Remember the open state of the category, Ensure that each View'…

feat: Remember the open state of the category, Ensure that each View's category is independent https://github.com/RSSNext/Follow/issues/602 https://github.com/RSSNext/Follow/issues/668

Sep 29 '24 05:09 Przeblysk

@Przeblysk is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

Sep 29 '24 05:09 vercel[bot]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: apps/renderer/src/store/subscription/store.ts

Function	Unhandled Issue
`morphResponseData`	TypeError: data is not iterable /Applications/Fol... `Event Count:` 5 `Affected Users:` 10

_{Did you find this useful? React with a 👍 or 👎}

Sep 29 '24 05:09 sentry[bot]

I can no longer see uncategorized feeds

Sep 29 '24 06:09 hyoban

I can no longer see uncategorized feeds

😯 I hadn't thought of that I'll revise it.

Sep 29 '24 06:09 Przeblysk

I can no longer see uncategorized feeds

I modified the display judgment, default display when feed is not grouped

https://github.com/RSSNext/Follow/pull/709/files#diff-59cf3a300e3e9c3e38aec7c41c219cfe98504302e861856f9799b1fd8c11b5d8R49

Sep 29 '24 06:09 Przeblysk

https://github.com/user-attachments/assets/88e0071c-83a5-4663-bc95-d1345b0cab69

I can't toggle the expanded state of automatic grouping by feed URL.

Sep 29 '24 06:09 hyoban

ScreenShot.2024-09-29.14.51.08.mp4 I can't toggle the expanded state of automatic grouping by feed URL.

Okay, I'll fix it.

Sep 29 '24 06:09 Przeblysk

ScreenShot.2024-09-29.14.51.08.mp4 I can't toggle the expanded state of automatic grouping by feed URL.

https://github.com/user-attachments/assets/2fbe771d-c460-4aab-a9c1-232bd72a4abe

I briefly tested it and it seems to be displaying fine

Sep 29 '24 07:09 Przeblysk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
follow	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 29, 2024 9:03am

Sep 29 '24 09:09 vercel[bot]

Should we save the open state to storage?

Sep 29 '24 15:09 hyoban

Should we save the open state to storage?

If we want to store in localStorage, do we only read Storage to initialize the Store when the application is ready, and then only update Storage before the application exits?

Sep 30 '24 01:09 Przeblysk

LGTM. Let's merge it, we may not need to persist the state to storage.

Thanks for your contribution.

Sep 30 '24 06:09 hyoban

After adding a subscription, it does not appear in the list immediately and needs to be refreshed before it can be displayed. Can you help take a look? @Przeblysk

Sep 30 '24 07:09 hyoban

After adding a subscription, it does not appear in the list immediately and needs to be refreshed before it can be displayed. Can you help take a look? @Przeblysk

Okay, I'll see what the problem is.

Sep 30 '24 08:09 Przeblysk

~~It should be OK after https://github.com/RSSNext/Follow/commit/b0a88312f52b2832d3b449aef15f5835b1cf3afc. Can you help verify it?~~

No

Sep 30 '24 08:09 hyoban

After adding a subscription, it does not appear in the list immediately and needs to be refreshed before it can be displayed. Can you help take a look? @Przeblysk

https://github.com/Przeblysk/Follow/blob/dev/apps/renderer/src/modules/feed-column/category.tsx#L49

The state of categoryOpenStateData is lagging, causing the Effect of shouldOpen to be executed 2 times. It should probably be explicitly set to the open state instead of using toggle. i'll look into why the value of categoryOpenStateData is old @hyoban

Sep 30 '24 08:09 Przeblysk