Folo icon indicating copy to clipboard operation
Folo copied to clipboard

feat: expand entry read history

Open hyoban opened this issue 1 year ago • 5 comments

Description

https://github.com/user-attachments/assets/1b612b35-c2ee-43d5-9fc5-09ac7b38b7d6

Linked Issues

Fixes #370 Fixes https://linear.app/follow-app/issue/FOL-126/follower过多无法展开

Additional context

https://github.com/RSSNext/follow-server/commit/7930d7370b4a408ec1f5f56c2e45cecca8872350

hyoban avatar Sep 13 '24 07:09 hyoban

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 6:13am

vercel[bot] avatar Sep 13 '24 07:09 vercel[bot]

I feel like a dropdown menu would be more appropriate here, using a modal would make it feel very cut off.

Innei avatar Sep 13 '24 07:09 Innei

But the number of read history user IDs can be up to 100 now.

https://github.com/RSSNext/follow-server/commit/7930d7370b4a408ec1f5f56c2e45cecca8872350

Or do we revert it and keep it 20?

hyoban avatar Sep 13 '24 07:09 hyoban

CleanShot 2024-09-13 at 4  49 32@2x

Just make it scrollable and infinite scrolling

Innei avatar Sep 13 '24 08:09 Innei

I do not know why. When I use drawer for UserProfileModal, it will open and quickly dismiss.

hyoban avatar Sep 14 '24 02:09 hyoban

I will fix that

Innei avatar Sep 14 '24 02:09 Innei

@hyoban

There is no problem with increasing the number of history records on the server side.

On the front end, it doesn't make sense to get to 100 records directly. Because in many cases users don't click More to see more users, the conversion rate is very low.

So to reduce the size of the data transfer and the pressure on the database itself. We should remove the entryReadHistories datafill from the entry interface on the server side, and then do the data paging in entries/read-histories/{id}.

In other words, there should be no read-histories queries or data in entries?id= right now. Instead, the API interface is separated into two.

Innei avatar Sep 14 '24 03:09 Innei

Got it, I'll take care of this part

hyoban avatar Sep 14 '24 03:09 hyoban

I do not know why. When I use drawer for UserProfileModal, it will open and quickly dismiss.

@hyoban I fix this bug

Innei avatar Sep 14 '24 04:09 Innei

@hyoban I'll merge it first, and then we can start a new branch to implement the above functionality.

Innei avatar Sep 14 '24 09:09 Innei