Folo icon indicating copy to clipboard operation
Folo copied to clipboard

chore: use self-hosted runner for android build

Open DIYgod opened this issue 8 months ago • 2 comments

Description

PR Type

  • [ ] Feature
  • [ ] Bugfix
  • [ ] Hotfix
  • [ ] Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • [ ] I have updated the changelog/next.md with my changes.

DIYgod avatar Apr 21 '25 14:04 DIYgod

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
follow ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2025 10:59am
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2025 10:59am

vercel[bot] avatar Apr 21 '25 14:04 vercel[bot]

Suggested PR Title:

fix: enhance runner detection in CI workflows

Change Summary: Updated CI workflow to dynamically select appropriate runners for Android and iOS builds based on their availability. Improved detection of available runners enhances build efficiency and reduces queue times.

Code Review:

Code Review

Issues Requiring Change Requests:

  1. File: .github/workflows/build-android.yml

    • Lines: 9-17
      • The RUNNER_GITHUB_TOKEN is being used directly in the curl command to authenticate API requests. However, RUNNER_GITHUB_TOKEN as a GitHub Actions secret should follow best practices, ensuring it is securely handled. It would be more secure to verify if the secret is appropriately masked or if environment variables need further protection.
      • Change Request: Confirm whether the RUNNER_GITHUB_TOKEN is securely configured and if it should be masked or scoped explicitly within this job.
  2. File: .github/workflows/build-ios-development.yml

    • Lines: 6-15
      • The changes replace self-hosted with macOS in runner labels. This might cause compatibility issues with existing self-hosted runners that rely on the previous label (self-hosted). If this modification was intentional, documentation or a warning should accompany the change to alert relevant users of the change.
      • Change Request: Validate the impact of changing "self-hosted" to "macOS" within runner labels for existing workflows and document or notify users if compatibility may be affected.
  3. File: .github/workflows/build-ios.yml

    • Lines: 6-15
      • Similar to the previous issue, the replacement of "self-hosted" with "macOS" in runner labels could cause compatibility problems with existing workflows that rely on the self-hosted label. It’s critical to assess the backward compatibility implications.
      • Change Request: Ensure that the transition from self-hosted to macOS runner labels does not disrupt existing workflows and provide appropriate documentation or notifications for affected users.

Summary of Review

The changes demonstrate enhancements to dynamic runner selection based on availability, which is a positive step toward optimizing workflow execution. However, the above issues related to security handling of secrets and backward compatibility with runner label modifications should be addressed to ensure reliable and secure operation of workflows.