rss-bridge
rss-bridge copied to clipboard
RSS-Bridge
Auto podcaster
convert a feed to a podcast (ie: add <enclosure>) based on simple heuristics.
Pull request artifacts
| Bridge | Context | Status |
|---|---|---|
| AutoPodcaster | 1 url (pr) | ⚠️ The feed has no items |
last change: Tuesday 2024-06-18 20:16:24
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
in essence this puts media urls into the enclosures property.
you still working on this?
in essence this puts media urls into the enclosures property.
yes
you still working on this?
I have it running on production, so yes. However, I don't want to bother you with a review until I bring it to a better level of quality. But of course, if you want to do an early review of this and give me some feedback of what I should improve, that's more than welcome!
i pushed a commit. might have introduced a bug by dropping
array_values.
hey thanks, much appreciated.
This leads me to wondering if what this PR really misses is some testing. WDYT?
And also: what "style" of unit testing would you prefer? narrower unit testing, or broader integration tests (which would require files to be uploaded somewhere)? The latter would be able to discover changes in archive.org output, but involves external resources in the testing chain, which is usually not appreciated.
i think current pr is good enough. i can see the value in extracting media from feed content and putting them into enclosure.
it's not a proper podcast/itunes format though. maybe we can improve that later.
it's not a proper podcast/itunes format though. maybe we can improve that later.
what do you mean? what's missing to be a proper podcast/itunes?
I will be happy to improve this if you have any suggestion, even after this gets merged in master.
this bridge simply adds audios to enclosures. podcast/itunes is much more than that