rss-bridge icon indicating copy to clipboard operation
rss-bridge copied to clipboard

Magikh42 steam app news use app name

Open Magikh42 opened this issue 1 year ago • 7 comments

Bridge: Steam App News

Hello, I added a checkbox to allow using the app name instead of author name, I think it's more practical for filtering by game in the user's preffered reader

I might have swapped commit messages and description but I don't know how to change that, sorry If someone can set the messages to what I put in the description it would be nice, thank you

Magikh42 avatar Feb 12 '24 13:02 Magikh42

Pull request artifacts

Bridge Context Status
SteamAppNews 1 untitled (current) ✔️
SteamAppNews 1 untitled (pr) ⚠️ (shutdown) 8192: Creation of dynamic property SteamAppNewsBridge::$app_name is deprecated in bridges/SteamAppNewsBridge.php line 59

last change: Tuesday 2024-03-19 10:50:28

github-actions[bot] avatar Feb 12 '24 13:02 github-actions[bot]

this will break existing feed urls because the tags parameter is gone.

dvikan avatar Feb 12 '24 19:02 dvikan

this will break existing feed urls because the tags parameter is gone.

Can you explain how it would break anything I don't understand The use_app_name is optional so previous feeds would still works using author name but new feeds could be generated using app name in place of author name

Magikh42 avatar Feb 14 '24 05:02 Magikh42

rss-bridge disallows url parameters who are not defined in the bridge.

(i consider this a bug but havent found time to fix it yet.)

so when tags is gone, it will fail on all existing feed urls.

dvikan avatar Feb 14 '24 14:02 dvikan

@otakuf pls help

dvikan avatar Mar 31 '24 02:03 dvikan

@otakuf pls help

what help, sry i don`t get it. Magikh42 want to add some functionality.

otakuf avatar May 19 '24 15:05 otakuf

@Magikh42

there are feeds out there using this bridge. they might be using the tags parameter in those urls.

if tags parameter is removed, these feeds will break. do you understand?

dvikan avatar Jun 18 '24 18:06 dvikan