rss-bridge icon indicating copy to clipboard operation
rss-bridge copied to clipboard

Splitting YoutubeBridge

Open em92 opened this issue 2 years ago • 4 comments

At the moment, if you visit some youtube profile you will be able to see at least these tabs.

  • Videos
  • Playlists
  • Broadcasts. Includes current, past broadcasts and future broadcasts
  • Shorts
  • Community. Bridge for this tab already exists which is maintained by @VerifiedJoseph

In current implementation, YoutubeBridge is expected to return latest videos from all tabs. At the moment of writing if we are not using duration_min/max params it does like expected [1]. If not, YoutubeBridge returns videos from "Videos" tab [2]. In given link am using very big number, that will include probably any video. Using profile, that posts mostly shorts and has only 2 videos in "Videos" tab.

[1] https://feed.eugenemolotov.ru/?action=display&bridge=YoutubeBridge&context=By+custom+name&custom=%40unreal_keanu&duration_min=&duration_max=&format=Html [2] https://feed.eugenemolotov.ru/?action=display&bridge=YoutubeBridge&context=By+custom+name&custom=%40unreal_keanu&duration_min=&duration_max=99999999&format=Html

As conclusion I would like to do this:

  • make bridges "YouTubeVideosTab", "YouTubePlaylistsTab", "YouTubeBroadcastsTab" and "YoutubeShortsTab" to output corresponding tabs. All bridges will have common code. "YoutubeShortsTab" won't have "duration_min/max" params, since all videos are short. YoutubeBroadcastsTab will also have option to exclude future and current broadcasts.
  • current "YoutubeBridge" will continue to return latest videos from channel. Feed in [2] should be consider as a bug in YoutubeBridge, and expected behavior in YouTubeVideosTabBridge.
  • "Playlist" option in YoutubeBridge should be hidden. YouTubePlaylistsTab and "Playlist" option in Youtube bridge should have same code. In short both should work. I am not sure if hiding context is available in current implementation of RSS-Bridge.

Opinions?

Related issue that is wrongly closed atm. https://github.com/RSS-Bridge/rss-bridge/issues/2308

em92 avatar Feb 26 '23 07:02 em92

I'd prefer to have a single bridge for all the youtube variants. If it makes it easier to code and maintain, sure go ahead and split out into multiple bridges. I don't use the youtube bridge much though. Need opinions from others.

dvikan avatar Feb 27 '23 07:02 dvikan

I see it just as a checkboxes in UI for each type of content. I want to paste youtube link, and expect rss bridge to offer me relevant checkboxes: videos, clips, live streams #3216, playlists, whatever it can fetch from given link, and then i can select what exactly i need.

As an and user i dont need separate bridge for each category, it is inconvenient

karrakoliko avatar Mar 03 '23 05:03 karrakoliko

I see it just as a checkboxes in UI for each type of content.

@vtuu, I already mentioned, that every tab should have different checkboxes.

"YoutubeShortsTab" won't have "duration_min/max" params, since all videos are short. YoutubeBroadcastsTab will also have option to exclude future and current broadcasts

em92 avatar Mar 11 '23 05:03 em92

btw i have refactored and improve the youtube bridge

dvikan avatar Oct 16 '23 01:10 dvikan