[PanneauPocketBridge] enhancements

[floviolleau]

• I noticed that ->innerText do not work while ->innerText() works
• renamed a variable do understand better
• add a parameter to getCities (function used for debugging)

[github-actions[bot]]

Pull request artifacts

file	last change
PanneauPocketBridge-current-context1	2022-08-26, 10:25:17
PanneauPocketBridge-pr-context1	2022-08-26, 10:25:17

[dvikan]

Can you give an example of what this pr fixes? Your first bullet point.

[floviolleau]

Hi @dvikan ,

On my side, if I use

$item['content'] = $itemDom->find('.sign-preview__content .content', 0)->innertext;

it doesn't work and if use this, it works:

$item['content'] = $itemDom->find('.sign-preview__content .content', 0)->innertext();

Can you please tell a bit more what do you expect from me?

[dvikan]

Which <select> option are you seeing this with?

[floviolleau]

<select> options?

It's for the title and the content of the RSS item the innerText

Sorry, but I don't understand what you mean

[dvikan]

The bridge has a list Choisir une ville where you select an option. The reason I ask is because I don't see a difference with your pr. I was testing with the first option.

EDIT: ->innertext and ->innertext() are equivalent. Maybe you are seeing cached results. Try touch DEBUG.

[floviolleau]

Ok understood.

Usually, when I play with a RSS feed, I set CACHE_TIMEOUT to 0.

On my side, all was empty when selecting the first option like you. No contents, no titles in the cards. I tried different cities and all was blank. When I changed to ->innerText() instead of ->innerText, all was filled in.

I develop every day with php and I didn't understood why causes that. I'm on a raspberry pi maybe this is the issue.

[dvikan]

The current bridge works fine for me. Notice that the property is case-sensitive and it must be ->innertext and NOT ->innerText.

The current bridge has:

$itemDom->find('.sign-preview__content .title', 0)->innertext

[floviolleau]

yes right, I missed type on comments. In the PR it is ->innertext().

I will try again on my server

[Bockiii]

@floviolleau progress?

[floviolleau]

Hi,

~Checking now~

I checked and without braces, it works. I didn't understood what happened. I changed the PR accordingly

Thanks