rss-bridge icon indicating copy to clipboard operation
rss-bridge copied to clipboard

Mandatory TEST_DETECT_PARAMETERS for bridges with defined detectParameters method

Open em92 opened this issue 2 years ago • 1 comments

If TEST_DETECT_PARAMETERS is not defined in bridge, but detectParameters is, project maintainer has to check if detectParameters works fine. Instead of manually checking, it could be better if correctness was checked automatically.

Previously mentioned in https://github.com/RSS-Bridge/rss-bridge/issues/2387 as "better bridge maintainance"

em92 avatar Mar 26 '22 20:03 em92

I'm guessing the detect logic is mostly unused. It's not visible in the web UI. It's beneficial for integration with ttrs etc. Someone might also have a personal bookmark for it. Having unittests like TEST_DETECT_PARAMETERS is nice but adds to the workload of a bridge writer. Also, the detect logic should ideally be applied in the html search form. That requires js which is a lot of work because bridge detect logic is currently in php-form.

dvikan avatar Apr 04 '22 19:04 dvikan