libvlc-sdk icon indicating copy to clipboard operation
libvlc-sdk copied to clipboard

Windows libs

Open apavlenko opened this issue 8 years ago • 1 comments

  1. I suggest the following improvement to the msvc.bat
set VC2013_DIR=C:\Program Files (x86)\Microsoft Visual Studio 12.0
call "%VC2013_DIR%\VC\vcvarsall.bat" x86_amd64

also it may be renamed to msvc2013.bat 2. I suggest the following improvement in the libvlc-sdk.pri

win32 {
## Windows common build here

!contains(QMAKE_TARGET.arch, x86_64) {
    ## Windows x86 (32bit) specific build here
    LIBS += $$PWD/lib/msvc/libvlc.lib
} else {
    ## Windows x64 (64bit) specific build here
    LIBS += $$PWD/lib/msvc/libvlc.x64.lib
}
} else ...
  1. why libvlccore.lib is created but is not used?

apavlenko avatar Mar 29 '16 10:03 apavlenko

it's helper, you don't need it. Just use libvlc-sdk directly.

  1. Then it will be better use VS120COMNTOOLS environment variable there.
  2. You could make Pull Request
  3. It was intended for use in out-of-tree libvlc plugins (https://github.com/RSATom/vmem2 for example). It shouldn't be used in any other ways.

RSATom avatar Mar 29 '16 11:03 RSATom