RLHD icon indicating copy to clipboard operation
RLHD copied to clipboard

Added functionality to allow "Impostor" objects to have lights, and added lights to various Imposter objects.

Open That-Canadian opened this issue 4 years ago • 4 comments

We can now add lighting to Impostor objects. Added an additional parameter constructor for "ObjectLight" which takes in the "ParentId" of the Object that is the "parent: to the Impostor we want to add light to, as well as the varp that controls which Impostor is showing so we can check for updates.

Used this to add lighting effects to the "Making Friends with My Arm" fire pits.

Reasoning behind the chosen Light values for the fire pits :

  • FIRE_OF_ETERNAL_LIGHT
    • Decided to go with a large, weak(er) slow pulse for these lights, because they are meant to "light" the entire underground area they are in, I thought it made sense to give them a more subtle pulse effect and larger radius.
  • The other pits I went with a flicker and a smaller size as it fits better (they aren't "lighting" and entire area, so more localized light emission seemed to make sense)

Testing : Tested locally, both on an account with the fire pits built and without. Also built a fire pit and confirmed lighting was added as soon as the Impostor changed.

That-Canadian avatar Sep 18 '21 18:09 That-Canadian

Also added lighting to the Hallowed Sepulchre Portal Frames, as those are imposter objects as well.

That-Canadian avatar Sep 18 '21 23:09 That-Canadian

this would be great functionality to have. just need to test it thoroughly before merging

RS117 avatar Sep 20 '21 18:09 RS117

Completely understand =) let me know if you have suggestions or questions about the implementation. I'm also running this build locally when I run the Sepulchre and haven't seen any abnormalities yet.

That-Canadian avatar Sep 20 '21 20:09 That-Canadian

These lights have finally made it in to the plugin :tada: https://github.com/117HD/RLHD/commit/b6c44292a6dfc6b319f35654724a7f9bc628cd4d

aHooder avatar Dec 11 '23 03:12 aHooder