Ingvar Stepanyan

Results 1089 comments of Ingvar Stepanyan

@Mingun No, it's not the same. The attribute you mentioned is for _implementing_ `Deserialize` via another type, while this issue is rather about _augmenting_ `Deserialize` on the same type. I...

The important difference is doing such augmentation transparently to the end type structure. Those important details are hidden under `...` in your snippet. For example, let's say you have ```rust...

Well, I don't agree, on practice it _is_ often important. It's basically same use-cases / reasons as `#[serde(default)]` or `#[serde(deserialize_with = ...)]` on individual fields, except sometimes you need to...

Yeah just seeing ellipsis forever, which is why I opened the console.

Oh... I see. Of course, it's uBlock Origin not liking the telemetry URL. Probably doesn't count like a bug, but perhaps the page could at least catch the `fetch` failure...

> Sorry if I missed something, but with #27 is the example in the Readme still correct? If the span fields are implemented, it feels like the example should read:...

At least as a temporary workaround, adding override for ```toml [patch.crates-io] tracing-forest = { git = "https://github.com/QnnOkabayashi/tracing-forest" } ``` makes the fields work as expected.

I think so, yeah! And what I'm seeing locally with latest Git version looks pretty good on my project too.

We already have that mechanism for arbitrary Module settings though, do we really need another named setting?

Idk, it seems like such a tiny saving (a few bytes of the `if`, and it's not even a repetitive pattern) that I'd say a separate setting/handling just to save...