Ingvar Stepanyan
Ingvar Stepanyan
Ah... Looks like it's because in the spec the functionality was moved to `navigator.storage.getDirectory()`: https://wicg.github.io/file-system-access/#sandboxed-filesystem PR would be welcome.
Ping @syrusakbary in case this one got missed as well.
We actually made own Rust wrapper for uap-core, and yes, we had to fix unnecessary escapes. Perhaps we could open-source it to avoid duplication of efforts?
> the only reason for that Only reason for what? Implementing Rust version of uap-core?
Ah. Well, another fix I had to do was to replace `\d` to match only ASCII digits, since it turned out to include Unicode ones as well, which should not...
Supporting `"` and `/` would solve all the cases where I had to manually (and carefully) unescape regexes before passing to `Regex::new` in several projects, so big 👍 here. I...
Yeah, exactly. I'm using `regex::bytes::Regex` to find arbitrary byte sequence in a larger byte sequence, and so I need to transform raw byte slice into a regex like `(?-u:\x01\x02...)` first...
FWIW this is what my current implementation looks like: ```rust fn escape(b: &[u8]) -> String { let mut regex_str = String::with_capacity(6 + b.len() * 4); regex_str += "(?-u:"; for b...
> Make sure your benchmarks give you sufficient coverage, because if they don't, you might have cases where a regex is slower than memmem. I tried on several small (
I meant sending a PR that would be accepted as a solution for now until someone says they need a different representation 😄