Ingvar Stepanyan comments

Results 1089 comments of


                                            Ingvar Stepanyan

Try blocks not identified as scope level

@michaelficarra Ah, I see where the misunderstanding came from. Agreed, that's a bug.

References to the explicitly declared variables in the global scope should be resolved as explicitlyResolved

Simple wrapping code into a IIFE fixes the issue, but I believe it should be "resolved" even when not wrapped.

References to the explicitly declared variables in the global scope should be resolved as explicitlyResolved

As far as I understand, `window.variable` can appear inside IIFE as well, so it doesn't really help if you avoid it only in the global scope. On the other hand,...

References to the explicitly declared variables in the global scope should be resolved as explicitlyResolved

In any case, ability to get them as `resolved` through flag would be definitely sufficient for my needs, everything else is just pure interest :)

References to the explicitly declared variables in the global scope should be resolved as explicitlyResolved

Thanks for a detailed explanation! > But I also think it's a little bit too stict ;) Yeah, I also think that people don't use `delete` often enough to make...

References to the explicitly declared variables in the global scope should be resolved as explicitlyResolved

Thanks!

MSYS2 I/O error: operation failed to complete synchronously

> Do we still need to do a new build of Rustup? Yes, this is still happening to me on MSYS as well: ``` $ curl --proto '=https' --tlsv1.2 -sSf...

Allow remapping all of line program when rewriting

Note: this is related to this comment: https://github.com/rustwasm/walrus/pull/71#issuecomment-545654296 by @philipc.

Allow remapping all of line program when rewriting

> Should we call `convert_address` on each individual instruction and recalculate offsets FWIW this seems most reasonable IMO, and doesn't require any API changes, but I'm not sure if there...

Allow remapping all of line program when rewriting

So for now I played with a branch to implement conversion directly in `convert_address` - that works somewhat fine, but tricky to extend correctly to relocations. But yeah personally I...