Ingvar Stepanyan comments

Results 1089 comments of


                                            Ingvar Stepanyan

[Discussion] Out-of-band signal for requesting Binary AST

@annevk > This would change that, no? I suppose that's true, yeah, although first we would need to have ECMAScript spec changes landed first to have something to link to....

[Discussion] Out-of-band signal for requesting Binary AST

I don't have any preferences regarding the mime type, so sounds good to me.

Consider merging LiteralInfinityExpression into LiteralNumericExpression

> But you should consider whether most usage will care to differentiate between finite and infinite numbers. Aside from stringification, currently other cases (like the one mentioned above) seem to...

Change triggers add event and change event

@shama Seems to be duplicate/part of #121.

Adding files on Windows does not fire events in any of modes

Node.js v0.10.28, Windows 8.1.

Adding files on Windows does not fire events in any of modes

Ok, let me know if there's anything I could help with.

Adding files on Windows does not fire events in any of modes

@c0bra How could case sensitivity affect watching? Or did you have some more specific pattern?

Adding file to a folder being watched doesn't catch and changing file --> show as deleted

Same issue here - on first change any file is emitted as `added` before `changed`.

Traverse down to new nodes in .replace()

I don't think you should modify parent from child's traversal. Better to do `if (...)` from your parent `BlockStatement`, in that case you will definitely have no side effects +...

estraverse breaking on comments inside conditions

@evindor Looks like the issue is you are calling [`attachComments(...)`](https://github.com/bramstein/amd-to-closure/blob/master/index.js#L149) **after** modifying AST, which means absolute positions it relies on are broken at moment of attachment.