Ingvar Stepanyan
Ingvar Stepanyan
I think you could reuse the https://github.com/microsoft/onnxruntime/blob/790018d2fbcfcd1128352a7289c076ffa4c63120/js/common/lib/type-helper.ts#L27 helper instead of rolling custom check.
Thanks for working on this! Just to be clear, I'm not a maintainer on this repo, we'll need for one of them to review too.
We could do that - at the cost of extra round-trip cost for each configuration descriptor, which is somewhat unfortunate - but I'm surprised as neither in official docs of...
> wMaxPacketSize 0x0200 1x 512 bytes I wonder if this is the actual limit - as in, 512 bytes would also work. If we can use wMaxPacketSize, then we don't...
> 256 doesn't work, unfortunately. Huh, fascinating. Okay, if there is no way around it, let's do 2 requests. I'm not near a computer right now, so could do this...
> I think we should keep `publish.rs` only for bumping the version. I think we can use cargo-release or cargo-smart-release for that. Actually, both say they handle workspace package dependencies...
> I have concerns that some users would already be providing an object to these methods and relying on `toString` behavior to create the label. That should be fine and...
Yeah I looked through it as well, and thought about reusing its return object, but it only helps for grouping, not other mentioned APIs.
Ran into the same issue, thought I'm going crazy and my implementation is incorrect. Sigh.
Note that this issue is particularly annoying when using the new file-scoped namespaces. When using those, (at least to me) it feels more natural to put `namespace ...` at the...