[Feature]: It should be possible to let players see the stat sheets of NPC tokens they do not own

[fishface60]

Describe the Problem

I have been designing my stat sheets as a way to present information to players about the monsters they face.

I was surprised to learn they could not see them despite setting the token properties such that the values were visible on the stat sheet to players and not GM or Owner specific.

After digging through the code to figure out why this might be I found:

if (MapTool.getPlayer().isGM()
    || AppUtil.playerOwns(token)
    || token.getType() != Type.NPC) {
  statSheet.setContent(
      event.token(),
      ssManager.getStatSheetContent(ssId),
      ssRecord.entry(),
      ssProperties.location());
}

It was confusing to learn that this is hard-coded after being able to have properties that are visible to non-owner and non-GM led me to believe that properties being visible to players did not extend to NPC tokens.

The Solution you'd like

I would like stat sheets of NPCs to be visible.

Unconditionally showing them would work for me, but potentially not for others.

Alternatives that you've considered.

1. Make all my NPC tokens into PC tokens so the stat sheets are displayed and keep the existing behaviour, though that mixes my NPC tokens in with my PC tokens in the map view.

2. Have a separate flag for whether stat sheets should be visible on NPCs, though if this is per-token that may be cumbersome.

3. Guess whether a stat sheet should be displayed by whether it has any properties.

   This has the problem of if you have a stat sheet for a token type that doesn't have properties it wouldn't be visible when you might want it to (e.g. publicly visible notes), and if the properties are accessible for other purposes such as macros then you might not want to have that cause the sheet to be displayed.

Additional Context

No response

[bubblobill]

@cwisniew change behaviour or add a checkbox?

[cwisniew]

@cwisniew change behaviour or add a checkbox?

I think the behaviour change is undesirable without toggling it on/off (defaulting to how it is now). It's been forever, and a day that players can't see NPC token pop-ups they don't own. I suspect there would be some real surprises for GM's if that behaviour suddenly changed. We can probably add it at the property type level (rather than individual properties) something along the lines of "Players can see NPC Stat-Sheet" option

[fishface60]

I would be very happy with a checkbox in the property type to toggle this on.

[timgstewart]

I've been trying to figure out why my statsheets that I spent a lot of time on worked for me, but didn't work for my players. I think it is this bug. As long as I use the "Legacy (pre 1.14 Stat Sheet)" option, players can see the monster stat sheets, minus the properties that are marked gm or owner only. However, if I pick any other stat sheet, the mouse over no longer works -- they can only see their own stat sheet. Hovering over a monster (NPC) just shows its name.

Any chance of getting this to work for stat sheets other than "Legacy (pre 1.14 Stat Sheet)" ? I had some cool animated stat sheets I wanted to use