maptool icon indicating copy to clipboard operation
maptool copied to clipboard

Published 20 hours ago • verified publisher icon RPTools

[Bug]: Ill-timed heartbearts cause handshake failures

Open kwvanderlinde opened this issue 2 months ago • 1 comments

Describe the Bug

If a client is in the middle of a handhsake, and the time comes for a heartbeat to be sent to the server, the handshake will be corrupted by the heartbeat and the connection will fail.

To Reproduce

  1. Start a server on one machine
  2. On another machine, run MapTool under a debugger.
    1. Set a breakpoint at the top of ClientHandshake.handleMessage
    2. Connect to the server
    3. Wait on the breakpoint for more than 20 seconds.
    4. Remove the breakpoint and continue.
  3. If all went well, the server will have received reported a MESSAGETYPE_NOT_SET and the client will be shown an error about incorrect passwords.

Expected Behaviour

Heartbeats should not be sent to the server during handshake. Handshakes complete very quickly after establishing a connection, and so there shouldn't even be an opportunity to lose the server unless something very drastic is happening.

Screenshots

No response

MapTool Info

develop

Desktop

Linux Mint 21.3

Additional Context

N/A

kwvanderlinde avatar May 10 '24 10:05 kwvanderlinde