[Bug]: Autosave failed me - unwanted behaviour

[bubblobill]

Describe the Bug

I pressed a button combo or put something in a macro editor pane that MT didn't like . It deleted the token containing all my unsaved work (I know, I know, mea culpa) Popped up an error message. Autosaved the campaign with the token deleted For all the hours it has been autosaving there is only one autosave file and it does not have the stuff I want to retrieve. No entries in the backup folder either - bummed out

Here's the log: 2022-09-09 13:07:53.055 ERROR net.rptools.maptool.client.MapTool - Macro Version 1.4 cannot be saved; token 275FA840960C4F21920DD34BAF4B664F no longer valid. 2022-09-09 13:08:38.306 INFO net.rptools.maptool.client.AutoSaveManager - Time to copy Campaign object (ms): 40 2022-09-09 13:08:38.307 INFO net.rptools.maptool.client.AutoSaveManager - Starting autosave... 2022-09-09 13:08:38.734 INFO net.rptools.maptool.client.AutoSaveManager - Autosave complete. Elapsed time (ms): 425

To Reproduce

sadly I cannot provide this

Expected Behaviour

I expected to find multiple autosaves/backups from which to recover my work

Screenshots

No response

MapTool Info

1.11.4

Desktop

Win 10

Additional Context

==== MapTool Information ==== MapTool Version: 1.11.4 MapTool Home...: C:\Users\Strat.maptool-rptools MapTool Install: C:\MapTool_1.11.4\app Max mem avail..: 3 GB Max mem used...: 494 MB Custom Property: -DMAPTOOL_LOGDIR=C:\Users\Strat.maptool-rptools\logs Custom Property: -DMAPTOOL_DATADIR=.maptool-rptools

==== Java Information ==== Java Home......: C:\MapTool_1.11.4\runtime Java Vendor....: Eclipse Foundation Java Version...: 16.0.2 Java Parameters: -Djpackage.app-version=1.0 -Xss32M -Dsun.java2d.d3d=false -Dsentry.environment=Production -Dfile.encoding=UTF-8 -Dpolyglot.engine.WarnInterpreterOnly=false -XX:+ShowCodeDetailsInExceptionMessages --add-opens=java.desktop/java.awt=ALL-UNNAMED --add-opens=java.desktop/java.awt.geom=ALL-UNNAMED --add-opens=java.desktop/sun.awt.geom=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=javafx.web/javafx.scene.web=ALL-UNNAMED --add-opens=javafx.web/com.sun.webkit=ALL-UNNAMED --add-opens=javafx.web/com.sun.webkit.dom=ALL-UNNAMED --add-opens=java.desktop/javax.swing=ALL-UNNAMED --add-opens=java.desktop/sun.awt.shell=ALL-UNNAMED -Djpackage.app-path=C:\MapTool_1.11.4\MapTool.exe

==== OS Information ==== OS Name........: Windows 10 OS Version.....: 10.0 OS Architecture: amd64 Processor......: Intel64 Family 6 Model 140 Stepping 1, GenuineIntel PATH...........: C:\MapTool_1.11.4;C:\Windows\Sun\Java\bin;C:\Windows\system32;C:\Windows;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Users\Strat\AppData\Local\Microsoft\WindowsApps;C:\Users\Strat\AppData\Local\GitHubDesktop\bin;. Number of Procs: 8

==== User Information ==== User Name: Strat User Home: C:\Users\Strat User Dir.: C:\MapTool_1.11.4

==== Network Interfaces ==== Display Name..: Software Loopback Interface 1 Interface Name: lo Address...: 127.0.0.1 Address...: 0:0:0:0:0:0:0:1

Display Name..: Intel(R) Wi-Fi 6 AX201 160MHz Interface Name: wlan1 Address...: 10.1.1.102 Address...: fe80:0:0:0:84b6:29c4:d503:fedb%wlan1

Host Address...: 10.1.1.102 Default Gateway: 10.1.1.1

==== Locale Information ==== Country.: Australia Language: English Locale..: English (Australia) Variant.:

==== Encoding Information ==== Default Locale: en_AU Default Charset: UTF-8 file.encoding: UTF-8 sun.jnu.encoding: Cp1252 Default Encoding: UTF8

==== Display Information ==== Number of Displays: 1 Display 1: 1920x1080(32)

==== Internet Gateway Devices ==== Device Name.: Archer_VR1600v Model Name..: Archer_VR1600v Manufacturer: TP-Link Model Number: 2.0 Model Desc..: AC1600 Wireless Dual Band Gigabit VoIP VDSL/ADSL Modem Router Firmware....: Linux/3.4.11-rt19, UPnP/1.0, Portable SDK for UPnP devices/1.6.19 External IP.: 103.129.157.34

[FullBleed]

Once upon a time there were like 10 "autosaves" at specific increments... probably was in the "backups" folder (since we know that the "autosave" is really a single file crash-recovery save, not a real "autosave" system) ... but not sure why the incremental auto-backups went away. That would help people in situations like this.

[Jmr3366]

So is this a bug or a feature request? I've seen two symptoms along these lines.

• If two MT instances are running, only one instance will be successfully autosaved when running from the same instanced folder (not sure if you can install the same version twice where this could be overcome)
• More autosaves by increase the count to whatever agreed number.

Not a bug then?

[FullBleed]

Seems like an "oversight" type of bug to me. Users often have two instances of MT running and if it's not properly auto and backup saving one of them that's a, potential, problem (i.e. it's currently unexpected, unintended, and undesirable behaviour.) I'll leave it to the devs to decide whether is a bug or a request to fix the issue.

Appending something to the saves that reflects the server/instance might help fix that issue but we really need more control over how many Auto Backups we want to allow in our system. As for "AutoSave" that really needs to be renamed to "Crash Recovery" and we need to be able to have multiple crash recovery files available with a selection option if more than one is found on boot up.