rpcs3 icon indicating copy to clipboard operation
rpcs3 copied to clipboard

Insanely high texture upload time - (engine using an allocator to place its object in vram) R&C ACiT

Open Yahfz opened this issue 4 years ago • 34 comments

This issue is more of a reminder-only to kd, as he knows exactly how to fix it so its best to keep it up here.

unknown

Yahfz avatar May 26 '20 19:05 Yahfz

image Killzone 2 and 3 also affected

Yahfz avatar Jun 07 '20 21:06 Yahfz

DiRT 3 seems to also be affected by this, going as high as 30ms. u31232131nknown

PawTM avatar Jun 07 '20 22:06 PawTM

Split/Second: Velocity is also affected a lot. SplitSecond

PawTM avatar Jun 07 '20 22:06 PawTM

And so is Far Cry 3: Blood Dragon, up to 30ms aswell. grafik

PawTM avatar Jun 07 '20 23:06 PawTM

Far Cry 2 is also affected Screenshot from 2020-06-07 20-20-51

RainbowCookie32 avatar Jun 07 '20 23:06 RainbowCookie32

MotorStorm: Pacific Rift might also just be affected? Not sure. Steady 10K-14K us texture upload times though.

image

dio-gh avatar Jun 08 '20 00:06 dio-gh

image F1 2014 may be affected, if it is then other codemasters racing games will be too

Jacoby1218 avatar Jun 08 '20 00:06 Jacoby1218

This is addressed by https://github.com/RPCS3/rpcs3/pull/9738 Upload times are still not amazing, but sub-10ms is good enough for me. Please verify.

kd-11 avatar Feb 09 '21 07:02 kd-11

This is addressed by #9738 Upload times are still not amazing, but sub-10ms is good enough for me. Please verify.

@kd-11 killzone 2-3 are indeed much better and sub 10ms. The bottleneck has shifted in the other games but farcry2 is still really bad hitting 81ms as you can see here:

Yahfz avatar Feb 09 '21 07:02 Yahfz

Motorstorm Pacific Rift still has high texture upload times

Satan86 avatar Feb 09 '21 08:02 Satan86

Some of these games may have the same root cause as the SSX issue. Its a similar bug to the one fixed in texture cache but now in the surface cache. Not overly complex to solve fortunately.

kd-11 avatar Feb 09 '21 10:02 kd-11

Test with https://github.com/RPCS3/rpcs3/pull/9772

kd-11 avatar Feb 13 '21 14:02 kd-11

This should have improved with recent additions, memory usage is closely monitored and cache eviction works now. I don't expect things to be completely fixed but at least should be improved.

kd-11 avatar Jul 30 '21 21:07 kd-11

Let's get a rebench here. I've done some work to significantly improve surface cache traversal times recently, and previously I optimized the regular texture cache as well. Things should have changed.

kd-11 avatar Mar 26 '22 08:03 kd-11

Far Cry 2 is still doing 20-30k us of upload time, looks about the same as my last test. Screenshot from 2022-05-05 11-49-41

Split/Second seems to be running fine aside from the graphical issues, no horrible upload times (on this area at least). Screenshot from 2022-05-05 11-58-11

RainbowCookie32 avatar May 05 '22 16:05 RainbowCookie32

Far Cry 2 is still doing 20-30k us of upload time, looks about the same as my last test.

200+ texture uploads per frame looks like something I need to investigate. The cause is likely different from the other games.

kd-11 avatar May 05 '22 17:05 kd-11

F1 2014 is at 4-5k us from my testing, way lower than previously reported (14k). Screenshot from 2022-05-05 18-41-09

Dirt 3 is at 1-3k us, running fine aside from random crashes. Screenshot from 2022-05-05 19-05-02

SSX is still a bit high, at 8-10k from my quick testing Screenshot from 2022-05-05 18-56-54

RainbowCookie32 avatar May 05 '22 22:05 RainbowCookie32

I looked into fc2, it has the same issues as kz2 & kz3 but worse. I'll come up with a solution.

kd-11 avatar May 05 '22 22:05 kd-11

Is ssx still high?

kd-11 avatar Jun 02 '22 09:06 kd-11

Far Cry 2 is still cursed, I'll try to retest ssx again later

RainbowCookie32 avatar Jun 05 '22 18:06 RainbowCookie32

Same as my previous report, 8-10k us

image

RainbowCookie32 avatar Jun 05 '22 19:06 RainbowCookie32

image 4512us FC2 Widows 11, Ryzen 5 3600, gtx 1660s RPCS3.log

Darkhost1999 avatar Aug 07 '22 22:08 Darkhost1999

12128us FC3 Widows 11, Ryzen 5 3600, gtx 1660s image RPCS3.log.gz

Darkhost1999 avatar Aug 18 '22 15:08 Darkhost1999

Some games require this combination:

  • Asynchronous texture streaming = true
  • Host GPU labels (advanced tab) = true
  • MTRSX = true (if your cpu can handle it, I'm not sure if it is needed) This drastically improves texture streaming performance on some setups, and gets some games like FC2 to a much better state.

kd-11 avatar Aug 18 '22 16:08 kd-11

Tracking improvement or change for these games involving high texture upload time values:

  • [x] R&C: A Crack in Time
  • [x] FarCry2 - 4,5k us
  • [ ] FarCry3 - 3,8k us @Darkhost1999 (waiting non debug)
  • [ ] MotorStorm 1
  • [ ] MotorStorm Pacific Rift @dio-gh @Satan86
  • [X] Split/Second
  • [X] DiRT 3
  • [X] F1 2014
  • [ ] SSX - 8/10k us @RainbowCookie32
  • [X] Killzone 2
  • [X] Killzone 3

Please let me know if I have incorrect data.

Meta comment

marcoluc97 avatar Aug 19 '22 15:08 marcoluc97

I don't think "a crack in time" still has high upload times. Correct me if I'm wrong on that one. I'm halfway through a fresh playthrough and there aren't too many issues other than some minor fps drops to report.

kd-11 avatar Aug 19 '22 17:08 kd-11

okay thanks i do not own that game so i look at comments here for others titles. the new #12530 PR improve something again in those games? updated the commet above

marcoluc97 avatar Aug 19 '22 18:08 marcoluc97

image Far cry 3 3308us texture upload time without using gpu texture scaling. RPCS3.log Far cry 3 can be ticked off

Darkhost1999 avatar Apr 15 '23 16:04 Darkhost1999

Screenshot 2023-04-15 122550 Motorstorm 3579us and without enhancement settings that makes the number even lower RPCS3.log Looks good to me

Darkhost1999 avatar Apr 15 '23 17:04 Darkhost1999

New tracking about improvement or change for these games involving high texture upload time values:

  • [X] R&C: A Crack in Time
  • [X] FarCry2 - 4,5k us
  • [X] FarCry3 - 3,8k us
  • [X] MotorStorm - 3,5k us
  • [ ] MotorStorm Pacific Rift - 15k @dio-gh @Satan86
  • [X] Split/Second
  • [X] DiRT 3
  • [X] F1 2014
  • [ ] SSX - 8/10k us @RainbowCookie32
  • [X] Killzone 2
  • [X] Killzone 3

Please let me know if I have incorrect data.

Meta comment

marcoluc97 avatar Apr 15 '23 18:04 marcoluc97