rpcs3 icon indicating copy to clipboard operation
rpcs3 copied to clipboard

wayland: try to fix display_handle_t type

Open Megamouse opened this issue 8 months ago • 2 comments

  • Use VK_USE_PLATFORM_WAYLAND_KHR instead of HAVE_WAYLAND in gs_frame

maybe fixes #17002

Megamouse avatar Apr 13 '25 10:04 Megamouse

VK_USE_PLATFORM_WAYLAND_KHR is a hack/workaround coming back to bite us. If you really think about it, as long as we have the right dependencies at compile time, we have no reason to not support both X11 and Wayland. The disambiguation of the handle type is supposed to be done at runtime and is handled. A proper fix should just remove this USE_PLATFORM_WAYLAND_KHR flag completely.

kd-11 avatar Apr 13 '25 11:04 kd-11

The issue on my laptop seems to be that VK_USE_PLATFORM_WAYLAND_KHR is false but HAVE_WAYLAND is true, which leads to this nonsense. Not sure if I can just use HAVE_WAYLAND for the display_handle_t instead without breaking anything. I can maybe test that later.

Megamouse avatar Apr 14 '25 06:04 Megamouse

Superceded by https://github.com/RPCS3/rpcs3/pull/17120

kd-11 avatar Apr 29 '25 00:04 kd-11