rpcs3 icon indicating copy to clipboard operation
rpcs3 copied to clipboard

VS: Fix zstd debug lib

Open Megamouse opened this issue 1 year ago • 7 comments

  • The zstd lib was building a dll and I randomly had the .lib somewhere in the folder, so it worked before cleaning it properly.
  • Update FAudio to 24.10
  • Update SDL to 2.30.8

Megamouse avatar Oct 03 '24 14:10 Megamouse

Debug build compiled successfully image Thank you

Darkhost1999 avatar Oct 03 '24 15:10 Darkhost1999

is it no longer needed to compile the projects under _BUILD_BEFORE (e.g. llvm_build)?

digant73 avatar Oct 03 '24 16:10 digant73

What makes you think that?

Megamouse avatar Oct 03 '24 16:10 Megamouse

What makes you think that?

because I didn't compile them. I simply built the solution and it compiled. But I didn't remove the existing bin folder

digant73 avatar Oct 03 '24 16:10 digant73

It's possible that you had them built before at some point

Megamouse avatar Oct 03 '24 16:10 Megamouse

The bin folder is not relevant for the build result and doesn't have to be cleaned

Megamouse avatar Oct 03 '24 16:10 Megamouse

The bin folder is not relevant for the build result and doesn't have to be cleaned

I see

It's possible that you had them built before at some point

yes possible. I thought that those dependencies were automatically compiled now. I will start from a clean repo

digant73 avatar Oct 03 '24 16:10 digant73

cloned your PR and compiled successfully also in Debug mode (not with cmake)

digant73 avatar Oct 04 '24 15:10 digant73

If I can suggest, for a next PR, better organized target compilation folders for the MSVC sln project I would follow the same approach used by the cmake project (also handled by VS 2022). The cmake project organizes all the compilation files (lib, obj etc.) inside the build-msvc main folder as shown in the following picture:

cmake_target_compile_folder

Currently, the MSVC sln project is creating folders directly on 3rdparty's source folder (source code mixed with .obj etc.) and also on different other folders in the rpcs3's main folder (e.g. lib, Release, Debug, x64 etc.)

digant73 avatar Oct 04 '24 19:10 digant73