rpcs3 icon indicating copy to clipboard operation
rpcs3 copied to clipboard

Bump LLVM to 18.1.8

Open kd-11 opened this issue 1 year ago • 3 comments

kd-11 avatar Sep 02 '24 19:09 kd-11

  • See 16.0.1 in BUILDING.md
  • See 16.0.1 in get_keys_windows.sh

Megamouse avatar Sep 27 '24 16:09 Megamouse

Needs conflict solved

Megamouse avatar Nov 22 '24 15:11 Megamouse

It needs a lot done actually. I'll try and fix it before end of year.

kd-11 avatar Nov 22 '24 19:11 kd-11

Downloaded from the llvm official repo both the source and pre-compiled llvm 18.1.8 version. In 3rdparty/llvm/CMakeLists.txt, the following changes need to be applied:

find_package(LLVM 16.0 CONFIG)

in

find_package(LLVM 18.1 CONFIG)

and

if (LLVM_VERSION VERSION_LESS 16)
    message(FATAL_ERROR "Found LLVM version ${LLVM_VERSION}. Required version 16 or above. \
        Enable BUILD_LLVM option to build LLVM from included as a git submodule.")

in

if (LLVM_VERSION VERSION_LESS 18.1)
    message(FATAL_ERROR "Found LLVM version ${LLVM_VERSION}. Required version 18.1 or above. \
        Enable BUILD_LLVM option to build LLVM from included as a git submodule.")

I could test it under Windows 11:

  • with CMake: with the above changes, I was able to successfully compile and build the application.
  • with Visual Studio: I was able to compile llvm with MSVC compiler while it failed with clang (some errors on some included Qt .h files). However the llvm libs (both the successfully compiled and the pre-compiled versions) failed on linking to rpcs3 (llvm seems to be compiled as /MD while rpcs3 was compiled as /MT)

digant73 avatar Dec 13 '24 14:12 digant73

In this case I know why it didn't build, I need to update some preset files. I just ran out of time, hopefully I'll get this done during the holidays.

kd-11 avatar Dec 13 '24 18:12 kd-11

18.1.7 seems to work. Can RPCS3 temporarily bump to that while investigating issues that cause 18.1.8 and onwards to have problems? There were a lot of changes from 16.0.1 to 18.1.7. Is the motivation behind 18.1.8 Github Actions? https://github.com/actions/runner-images/blob/win22/20241215.1/images/windows/Windows2022-Readme.md

Darkhost1999 avatar Jan 06 '25 02:01 Darkhost1999

Holidays came and went lol. Windows LLVM packages were fixed last year already, so I just need to fix those preset files. We had already upgraded *nix to 18.x so nothing to do there.

kd-11 avatar Jan 23 '25 22:01 kd-11