rpcs3 icon indicating copy to clipboard operation
rpcs3 copied to clipboard

cellSaveData: Add autosave indicator

Open NicknineTheEagle opened this issue 1 year ago • 5 comments

This adds standard autosave and autoload indicators that would appear on PS3 when the game requests them. Since RPCS3 saves basically instantaneously, this auto indicator simply appears for a few seconds to let the user known when the game autosaves.

NicknineTheEagle avatar Jun 22 '24 11:06 NicknineTheEagle

Can you please add a feature where... when the autosave indicator appears and you go to close the emulator, it opens a prompt saying:

"Closing while saving may cause damage to your save. Are you sure you want to close the emulator?"

- "Yes / No"

I like this feature in PCSX2. It's probably unnecessary because RPCS3 saving is so fast, but I would rather be safe than sorry, and it might even help prevent users reporting issues that are user error.

jeremybris avatar Jun 22 '24 13:06 jeremybris

"Closing while saving may cause damage to your save. Are you sure you want to close the emulator?" - "Yes / No"

It's not relevant for RPCS3, our saves are superior.

elad335 avatar Jun 22 '24 14:06 elad335

Was testing something / not intended for merge yet

elad335 avatar Jun 28 '24 17:06 elad335

Did you forget about the review changes @NicknineTheEagle ?

Megamouse avatar Jul 19 '24 17:07 Megamouse

Did you forget about the review changes @NicknineTheEagle ?

Ah, sorry - no, I didn't forget, I was just procrastinating on this because I need to add UI element to toggle the feature and I really don't like working with anything UI.

NicknineTheEagle avatar Jul 19 '24 17:07 NicknineTheEagle

if this PR is still valid on top of the current RPCS3, isn't it good to be merged (applying the changes provided by megamouse) and then someone else could make this feature configurable on the GUI, if necessary?

digant73 avatar Aug 14 '24 12:08 digant73

@NicknineTheEagle check your repo. I opened a PR to add the GUI support + the reviews proposed here

digant73 avatar Oct 30 '24 22:10 digant73

@NicknineTheEagle check your repo. I opened a PR to add the GUI support + the reviews proposed here

Thank you.

NicknineTheEagle avatar Oct 31 '24 18:10 NicknineTheEagle