rpcs3 icon indicating copy to clipboard operation
rpcs3 copied to clipboard

PPU LLVM: Fix optimization of branch string

Open elad335 opened this issue 2 years ago • 10 comments

Turns out the branch optimization in #14616 was not active, this enables it.

elad335 avatar Sep 05 '23 08:09 elad335

Improves performance on Demon's Souls.

Master: 63.8/69.8/75.3 FPS Demons Souls framerate 2

PR: 66.7/71.4/75.1 FPS Demons Souls framerate 1

Ordinary205 avatar Sep 05 '23 14:09 Ordinary205

Seems more or less the same in MGS4 with slightly better lows/avg in this scene.

I tested other areas as well and I didn't see a difference.

Master: Screenshot from 2023-09-05 15-12-34

PR: Screenshot from 2023-09-05 15-15-20

cipherxof avatar Sep 05 '23 22:09 cipherxof

I forgot to mention that if you want to be benefited from you have to delete cache.

elad335 avatar Sep 06 '23 02:09 elad335

The game closes when trying to compile PPU modules on a fresh cache.

E PPU: LLVM: Verification failed for v6-kusa-Kh8ANdpJ7R8TYsfsPsw6ct-00001P-icelake-client.obj:
Instruction does not dominate all uses!
%58 = add i64 4336, %2
store i64 %58, ptr %51, align 8

RPCS3.log.gz

cipherxof avatar Sep 07 '23 07:09 cipherxof

good can not download why?

Juan12233 avatar Sep 09 '23 06:09 Juan12233

Any further testing needed?

jgt11 avatar Sep 13 '23 22:09 jgt11

Well it seems some problem occured?

ghost avatar Sep 13 '23 22:09 ghost

Comparing build 15620 and this PR, with fresh PPU-SPU caches. Game version 1.12

PR Screenshot (4)

Build 15620 Screenshot (5)

Disregard the frametime spike as Windows sometimes stutters while taking an SS. On an another note, this is what the game looks like when you boot it the first time after clearing caches with PR build. Untitled

and if you load into the level performance is basically horrible, though if you restart the game everything is normal.

With build 15620, interestingly menu has the same glitchy look but its also stuttering.

Untitled2

Which is again fixed by rebooting the game. Might be a new issue as its been a long time since I did the startup sequence of this game.

franklypaladin avatar Sep 14 '23 23:09 franklypaladin

Which is again fixed by rebooting the game. Might be a new issue as its been a long time since I did the startup sequence of this game.

It's not caused by this PR.

Yahfz avatar Feb 04 '24 16:02 Yahfz

Just checking to see if this was forgotten about?

FarmerJoe7355 avatar Nov 14 '25 15:11 FarmerJoe7355