rpcs3
rpcs3 copied to clipboard
RPCS3
fix toolbar text color in dark theme
RPCS3 uses some custom stylesheets to customize the toolbar. However, these styles bring serious usability issues on Linux and macOS when users choose dark theme. The action button text is very hard to read:
This PR disabled these styles in favor of default Qt Widgets styles. In result, it show correct colors in both light and dark mode:
Fix #12707 #12065
The issue isn't the stylesheet. The issue is that stylesheets in general don't work properly when using a system wide override on macOs and some linux platforms. So the "fix" would be to hope that a newer Qt version has this sorted out or to use a different stylesheet or even a proper style instead of a stylesheet (see command line args with --help).
It's not an issue on Windows because there Qt defaults to ignoring system wide styles. (which should be normal on any proper platform)
@Megamouse older version Windows + Qt has very limited support for system color mode. However, this will change in future. See https://www.qt.io/blog/dark-mode-on-windows-11-with-qt-6.5 In the end, all systems will have the same issue.
If you spend some time check issues, you will find out why people need it. Anyway, we are already shipping patched version for openSUSE Linux users and people like it.
It's not an issue on Windows because there Qt defaults to ignoring system wide styles. (which should be normal on any proper platform)
If the operating system has a way to set up system-wide styles then I would have assumed that most people would expect those styles to apply system-wide. My opinion is that the default should be to respect system-wide styles, not ignore them (by all means, have an option to override them, but it seems strange to me to ignore the user's preferences by default).
However, I digress. If I understand correctly then the game list background is being specified as white, but the text colour isn't specified at all. The OS could therefore legitimately make it black, or white, or even red-and-purple striped with a gold trim. I'm not familiar with Qt but I can't imagine that it would be difficult to specify both the foreground and background, fixing the issue (albeit forcing light mode, but that's better than having an unreadable game list).
PS. It's unclear from the screenshots whether this PR actually fixes the issue with list view, as the "after" screenshots only show grid view (which already works, at least under MacOS).
@Behodar currently I only fixed color of the toolbar. neither list view or grid view are changed. (I use grid view only) If people are interested, I can keep updating this patch.
Btw, you can just set a style using cli args, which would circumvent the use of a stylesheet.
I'll close this PR due to inactivity. I provided a way to use native styles using the settings dialog in another PR: #14915
Apparently the Qt developers are working on better control over the dark mode. So I expect to be able to force the application to use the bright mode while using stylesheets in the nearish future, as currently all stylesheets work well with the bright default styles.
I'll try to fix the existing bright stylesheets in the meantime. I think they are just missing some default fore and back colors.
You said my PR "make no sense" and now you are doing the same thing in your own PR? I deserve an apologias.