rpcs3 icon indicating copy to clipboard operation
rpcs3 copied to clipboard

Regression: Tron: Evolution [BLUS30457] bloom broken (#10733)

Open legend800 opened this issue 4 years ago • 10 comments

Bloom broken by this commit: https://github.com/RPCS3/rpcs3/pull/10733

Build before (12649): 2021-11-07 13_37_08-Window

PR: 2021-11-07 13_46_47-Window

Other example: 2021-11-07 13_50_49-Window

RPCS3.log.gz

Config: Windows 10 64-bit GeForce GTX 3070 AMD Ryzen 5900x 32GB RAM

legend800 avatar Nov 07 '21 21:11 legend800

Needs some kind of capture, renderdoc or RSX capture will suffice.

kd-11 avatar Nov 09 '21 18:11 kd-11

Tiny problem with this regression report - it references a known-bad PR. The dynamic indexed loads were implemented properly later. This is what it actually looks like a few weeks after the mentioned PR:

image

I'm not able to tell if anything is wrong from the capture, it seems bloom is working as intended. This game has some very intense bloom by design and you probably also need WCB to enable a full classic HDR pipeline.

kd-11 avatar Apr 22 '22 17:04 kd-11

Is it possible to get some matching shots of rpcs3 vs ps3?

kd-11 avatar Apr 22 '22 17:04 kd-11

I only noticed this issue on that 1 single chapter of that 1 room. It's a minor enough issue that you could miss it and never realize there was an issue at all. And yes can get updated information with ps3 capture as well.

Darkhost1999 avatar Apr 22 '22 17:04 Darkhost1999

Thanks. That would help a lot. Remember to enable WCB (and maybe RCB too) when getting the rpcs3 shot. From the before and after comparison, it is obvious bloom was broken before the PRs and working after, so the question is just to check how different the new behavior is vs native PS3.

kd-11 avatar Apr 22 '22 17:04 kd-11

@kd-11 Here's everything. This is definitely not rendering correctly.

Latest master build: 2022-04-22 14_19_25-FPS_ 30 00 _ Vulkan _ 0 0 21-13478 _ Tron_ Evolution  BLUS30457

Real - 2022-04-22 14_25_45-(27) TRON_ Evolution FULL GAME Longplay (PS3, X360, PC) - YouTube — Mozilla Fire

RPCS3.log.gz

Capture: https://drive.google.com/file/d/1Hy8zuMrE1HK5rSr43EOrLlAnQbT_WlNk/view?usp=sharing

legend800 avatar Apr 22 '22 21:04 legend800

Thanks

kd-11 avatar Apr 22 '22 21:04 kd-11

Still an issue as of 0.24.14141 (Sep '22). 2022-09-10 09_09_28-FPS_ 29 97 _ Vulkan _ 0 0 24-14141 _ Tron_ Evolution  BLUS30457

legend800 avatar Sep 10 '22 16:09 legend800

Still an issue on 0.0.27-15035-73dba6d6 (May '23). 2023-05-20 16_00_27-FPS_ 29 93 _ Vulkan _ 0 0 27-15035 _ Tron_ Evolution  BLUS30457

legend800 avatar May 20 '23 23:05 legend800

Still an issue on 0.0.28-15215-073b723c RSX capture BLUS30457_20230620181602_capture.zip

kotenok2000 avatar Jun 20 '23 15:06 kotenok2000

Still an issue, tested with the latest master build: (rpcs3-v0.0.30-15912).

Emulator-Team-2 avatar Jan 04 '24 20:01 Emulator-Team-2