ROSS icon indicating copy to clipboard operation
ROSS copied to clipboard

WIP: Update network-mpi.c

Open caitlinross opened this issue 6 years ago • 2 comments

Dan's Version of network-mpi.c with queue

Dan, I'm creating a pull request so I can add in comments/feedback to specific lines of your code.


If this merge represents a feature addition to ROSS, the following items must be completed before the branch will be merged:

  • [ ] Document the feature on the blog (See the Contributing guide in the gh-pages branch). Include a link to your blog post in the Pull Request.
  • [ ] One or more TravisCI tests should be created (and they should pass)
  • [ ] Through the TravisCI tests, coverage should increase
  • [ ] Test with CODES to ensure everything continues to work

caitlinross avatar Jul 19 '18 13:07 caitlinross

@yaciud is this still a work in progress? Or, is this branch in some final state that works for you?

gonsie avatar Sep 30 '19 17:09 gonsie

I consider it a work in progress, but progress on it has stalled. In quick succession the May update to ROSS happened and the clusters I had access to got wiped or had a malfunction, so my code became outdated and it became difficult to test. I believe I have versions that work with the current version of ROSS, but there are still remnants from the outdated MPI layer in there that I'd like to get rid of before considering the work in its final stage.

Also by versions I mean that I have a 3 different ways of solving the problem written and working. I'd like to optimize 2 of them a little bit more, but they all seem to be improvements over the original network layer. It would probably take less than 2 days to get everything ready if needed.

yaciud avatar Sep 30 '19 18:09 yaciud