rccl icon indicating copy to clipboard operation
rccl copied to clipboard

replacing rccl_float8 with hip_fp8 and address compatibility issue

Open corey-derochie-amd opened this issue 9 months ago • 2 comments

Details

Work item: _ [LWPCOMMLIBS-576]

What were the changes?
move to HIP FP8 header file

Why were the changes made?
RCCL needs to switch over to HIP FP8 header file which has become available in recent ROCm releases.

How was the outcome achieved?
RCCL-UT and rccl-tests have been tested and passed with datatype=FP8.

Additional Documentation:
What else should the reviewer know? For gfx942, we need to support FP8_FNUZ, as the OCP type is currently unsupported. Additionally, we should retain the current RCCL internal header file to ensure compatibility with older ROCm releases that lack the HIP FP8 header.

Approval Checklist

Do not approve until these items are satisfied.

  • [ ] Verify the CHANGELOG has been updated, if
    • there are any NCCL API version changes,
    • any changes impact library users, and/or
    • any changes impact any other ROCm library.

corey-derochie-amd avatar Feb 13 '25 17:02 corey-derochie-amd

/AzurePipelines run rccl develop PR

jayhawk-commits avatar Mar 21 '25 20:03 jayhawk-commits

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 21 '25 20:03 azure-pipelines[bot]