rccl icon indicating copy to clipboard operation
rccl copied to clipboard

[Feature]: Remove hipify as a build dependency.

Open trixirt opened this issue 1 year ago • 3 comments

Suggestion Description

hipify is only needed to run when the nccl codebase is updated. Can hipify be moved to a maintainers options and a ci system generate/commit the hipified code ? This would reduce the complexity and speed up the build.

Operating System

ALL

GPU

ALL

ROCm Component

RCCL

trixirt avatar Dec 17 '24 00:12 trixirt

yeah i second this, its pretty silly having to use hipify at compiletime on a first party lib.

IMbackK avatar Dec 17 '24 07:12 IMbackK

we'll look into this hipified-code-only approach. however, most of the build time is spent in the linking stage... let us know if you measured something different. also, you can reduce build time by building only for local GPU architecture using ./install.sh -l

nileshnegi avatar Dec 17 '24 07:12 nileshnegi

For me this would be more about the benefit of a lessened dependency and the complexity of having to debug the hipifyed code while going back and forth between the original cuda and the generated hip.

The compile time is not a factor for me.

IMbackK avatar Dec 17 '24 09:12 IMbackK