pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Sow ms7 enable test reference numerics small all except complex

Open bmedishe opened this issue 2 years ago • 7 comments

This PR is to enable tests which are skip on rocm from test package test_unary_ufuncs.py::TestUnaryUfuncsCUDA

test_file test_name test_class
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_tan_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_bfloat16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_int8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_uint8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_int8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_uint8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_int8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_uint8 (main.TestUnaryUfuncsCUDA)

bmedishe avatar Nov 02 '22 21:11 bmedishe

These tests were skipped from PR Various OpInfo architecture improvements few tests belonging to this package were enabled for rocm in ROCM: Enable few more tests for ROCM

Before PR PYTORCH_TEST_WITH_ROCM=1 pytest -s test_unary_ufuncs.py::TestUnaryUfuncsCUDA 12428 passed, 514 skipped, 17 xfailed, 15 warnings After PR PYTORCH_TEST_WITH_ROCM=1 pytest -s test_unary_ufuncs.py::TestUnaryUfuncsCUDA 12467 passed, 475 skipped, 17 xfailed, 15 warnings

bmedishe avatar Nov 02 '22 21:11 bmedishe

jenkins retest this please

pruthvistony avatar Nov 07 '22 05:11 pruthvistony

@bmedishe , Please check the CI logs to ensure if the new UTs are getting executed and if it is executed, can you please post the logs in comments.

pruthvistony avatar Nov 07 '22 05:11 pruthvistony

jenkins retest this please

bmedishe avatar Nov 14 '22 17:11 bmedishe

All the above tests pass in upstream CI https://github.com/pytorch/pytorch/actions/runs/3465630790/jobs/5788831616

bmedishe avatar Nov 15 '22 16:11 bmedishe

@bmedishe , Can you raise this change to upstream pytorch/pytorch and another PR into rocm5.5_internal_testing branch

pruthvistony avatar Jan 20 '23 08:01 pruthvistony

@bmedishe , Can you raise this change to upstream pytorch/pytorch and another PR into rocm5.5_internal_testing branch

@pruthvistony upstream PR which is merged https://github.com/pytorch/pytorch/pull/89007
will file a PR on rocm5.5_internal_testing branch

bmedishe avatar Jan 20 '23 20:01 bmedishe