hipFFT icon indicating copy to clipboard operation
hipFFT copied to clipboard

Build homogeneity for CMake options?

Open marcodelapierre opened this issue 4 years ago • 4 comments

Both hipBLAS and hipSOLVER use "USE_CUDA=ON" to specify a CUDA backend build, whereas hipFFT currently uses "BUILD_WITH_LIB=CUDA". (hipSPARSE uses yet another one)

It would probably ease installation efforts if the syntax could be made more homogeneous.

Thanks,

marcodelapierre avatar Sep 21 '21 08:09 marcodelapierre

Thanks for raising this issue. We're discussing how best to solve this - one advantage of "BUILD_WITH_LIB=CUDA" is that we can specify other libs, besides ROCM and CUDA, of we decide to support these in the future. But having the same syntax between the libraries is definitely a good idea.

malcolmroberts avatar Sep 23 '21 15:09 malcolmroberts

I agree with the larger flexibility allowed by your current syntax..so perhaps that's the one to be used across all HIP numerical libraries? Probably a good conversation with teams working on the other ones (hipBLAS, SOLVER, SPARSE, ..)

marcodelapierre avatar Sep 24 '21 01:09 marcodelapierre

Absolutely. I have brought this up with the team, and I will see what we can agree on.

malcolmroberts avatar Sep 24 '21 15:09 malcolmroberts

There is an internal ticket tracking this feature request. Thanks!

ppanchad-amd avatar Jul 09 '24 14:07 ppanchad-amd