composable_kernel icon indicating copy to clipboard operation
composable_kernel copied to clipboard

Extract common code from example/test/profiler

Open poyenc opened this issue 2 years ago • 0 comments

There are lots of duplicated codes in implementations, like the HostTensorDescriptor creation logic.

auto f_host_tensor_descriptor1d = [](std::size_t len, std::size_t stride) {
	return HostTensorDescriptor({len}, {stride});
};

auto f_host_tensor_descriptor2d =
	[](std::size_t row, std::size_t col, std::size_t stride, auto layout) {
		if(std::is_same<decltype(layout), ck::tensor_layout::gemm::RowMajor>::value)
		{
			return HostTensorDescriptor({row, col}, {stride, 1_uz});
		}
		else
		{
			return HostTensorDescriptor({row, col}, {1_uz, stride});
		}
	};

I suggest put those kinds of utilities into a shared headers in order to reduce maintenance effort.

poyenc avatar Sep 28 '22 08:09 poyenc