composable_kernel icon indicating copy to clipboard operation
composable_kernel copied to clipboard

[CK_TILE] Move DataTypeTraits into a Common File

Open arai713 opened this issue 1 month ago • 0 comments

In CK Tile, DataTypeTraits is used to print out the datatype name when given a datatype in examples and test files.

template <typename T>
struct DataTypeTraits;

template <>
struct DataTypeTraits<float>
{
    static constexpr const char* name = "fp32";
};

template <>
struct DataTypeTraits<ck_tile::half_t>
{
    static constexpr const char* name = "fp16";
};

There is duplication of the DataTypeTraits struct across CK Tile. This PR renames typeToStr in the common utility file (include/ck_tile/ops/common/utils.hpp) to DataTypeTraits and removes all duplication of DataTypeTraits .

Upon testing the changed examples/tests, there were a few CK Tile examples that did not compile or validate, some of which have been mentioned here. A separate ticket will be opened for these.

Proposed changes

Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • [ ] I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • [ ] I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • [ ] I have added inline documentation which enables the maintainers with understanding the motivation
  • [ ] I have removed the stale documentation which is no longer relevant after this pull request
  • [ ] (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • [x] I have run clang-format on all changed files
  • [ ] Any dependent changes have been merged

arai713 avatar Nov 03 '25 18:11 arai713