composable_kernel icon indicating copy to clipboard operation
composable_kernel copied to clipboard

enable testing for all hdim supported in fmha_fwd

Open aska-0096 opened this issue 2 months ago • 4 comments

Proposed changes

Enable hdim=96/160/192 instances in fmha fwd and turn on tests for them.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • [ ] I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • [ ] I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • [ ] I have added inline documentation which enables the maintainers with understanding the motivation
  • [ ] I have removed the stale documentation which is no longer relevant after this pull request
  • [ ] (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • [ ] I have run clang-format on all changed files
  • [ ] Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

aska-0096 avatar Sep 24 '25 02:09 aska-0096

This needs to be gtest, not a script!

illsilin avatar Sep 24 '25 14:09 illsilin

This needs to be gtest, not a script!

Is that means we'd better deprecate the smoke_test script?

aska-0096 avatar Sep 25 '25 05:09 aska-0096

Can you please resolve merge conflicts?

illsilin avatar Sep 29 '25 22:09 illsilin

This needs to be gtest, not a script!

Is that means we'd better deprecate the smoke_test script?

yes, i think the smoke test could be disabled. we may only continue to run the benchmarks to keep collecting the daily performance numbers.

illsilin avatar Oct 14 '25 15:10 illsilin