composable_kernel icon indicating copy to clipboard operation
composable_kernel copied to clipboard

Add attn sink

Open LJ-underdog opened this issue 2 months ago • 2 comments

Proposed changes

Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • [x] I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • [x] I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • [x] I have added inline documentation which enables the maintainers with understanding the motivation
  • [x] I have removed the stale documentation which is no longer relevant after this pull request
  • [x] (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • [x] I have run clang-format on all changed files
  • [x] Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

LJ-underdog avatar Sep 22 '25 09:09 LJ-underdog

@LJ-underdog @DDEle Can you create a PR in the AITER repo, reference it here and update the description? Once AITER PR is passing, then we can move this one ahead. Thanks!

cgmillette avatar Oct 30 '25 17:10 cgmillette

@LJ-underdog @DDEle Can you create a PR in the AITER repo, reference it here and update the description? Once AITER PR is passing, then we can move this one ahead. Thanks!

There is a PR in the AITER repo, it is already being tested. https://github.com/ROCm/aiter/pull/1272

LJ-underdog avatar Oct 31 '25 01:10 LJ-underdog