composable_kernel icon indicating copy to clipboard operation
composable_kernel copied to clipboard

[CK_TILE] Epilogue chaining (Lwpck 3373)

Open amd-yashagar opened this issue 3 months ago • 3 comments

Proposed changes

The EpilogueChainer allows to stack epilogues one after the other and run them sequentially.

The EpilogueChainer implementation is demonstrated using the cshuffle epilogue by breaking and chaining it. The breaking and testing of the cshuffle epilogue is taken from #2729, hence this also has the row/col scaling. The example shows how the epilogues are modular and can sort of plugged-in if needed.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • [ ] I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • [ ] I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • [ ] I have added inline documentation which enables the maintainers with understanding the motivation
  • [ ] I have removed the stale documentation which is no longer relevant after this pull request
  • [ ] (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • [ ] I have run clang-format on all changed files
  • [ ] Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

amd-yashagar avatar Sep 03 '25 13:09 amd-yashagar

PR also seems a good candidate to be added to CHANGELOG.md

AviralGoelAMD avatar Sep 11 '25 16:09 AviralGoelAMD

@spolifroni-amd Thank you for the review, I have made the suggested changes.

amd-yashagar avatar Sep 26 '25 16:09 amd-yashagar

Just converted to draft as we still discuss the design.

aosewski avatar Oct 21 '25 12:10 aosewski