composable_kernel icon indicating copy to clipboard operation
composable_kernel copied to clipboard

Fix set_slice_tile API and sequence hisogram function

Open aska-0096 opened this issue 9 months ago • 1 comments

Proposed changes

Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • [ ] I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • [ ] I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • [ x I have added inline documentation which enables the maintainers with understanding the motivation
  • [x] I have removed the stale documentation which is no longer relevant after this pull request
  • [x] (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • [x] I have run clang-format on all changed files
  • [x] Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

aska-0096 avatar Mar 04 '25 08:03 aska-0096

This PR includes #1927 from @ClementLinCF , 1927 will be closed because it's from personal folks instead of ROCm repo branch.

aska-0096 avatar Mar 04 '25 08:03 aska-0096

Hi @qianfengz Synced the develop, we can merge after CI pass

aska-0096 avatar Jun 04 '25 06:06 aska-0096

Hello @aska-0096 @qianfengz this PR is stale for several months. Please notify me whether to close it or to move forward with additional code review.

For your PR to be considered for code review, please fill out the appropriate descriptions, checkboxes and relevant discussions.

cgmillette avatar Oct 08 '25 22:10 cgmillette

No response from the PR owner. Closing - There were recent related changes: https://github.com/ROCm/composable_kernel/pull/2430

aosewski avatar Oct 23 '25 11:10 aosewski