composable_kernel icon indicating copy to clipboard operation
composable_kernel copied to clipboard

Check compiler flags before using

Open trixirt opened this issue 1 year ago • 3 comments

The user's compiler may not support these flags, so check. Resolves failures on Fedora.

trixirt avatar Jul 21 '24 10:07 trixirt

Unfortunately, this PR breaks 2 tests in our CI:

[2024-07-25T21:33:39.047Z] The following tests FAILED: [2024-07-25T21:33:39.047Z] 251 - test_gemm_universal (Failed) [2024-07-25T21:33:39.047Z] 268 - test_grouped_convnd_fwd (Failed)

Please make sure all tests are passing, then re-submit.

illsilin avatar Jul 25 '24 23:07 illsilin

I can not see the details on the failures, on a working build with a compiler that supported these options this should have been a noop. is a non working compiler being used and the warnings of unsupported cmd line options being ignored later?

trixirt avatar Jul 30 '24 22:07 trixirt

The tests failed with the default ROCm6.1 compiler.

illsilin avatar Jul 31 '24 15:07 illsilin

Let's see how this is going to work with rocm6.2 compiler.

illsilin avatar Aug 14 '24 19:08 illsilin

Looks like the cause of the failures was the comma in the original commit:

check_cxx_compiler_flag("-mllvm -enable-post-misched=0", HAS_ENABLE_POST_MISCHED)

illsilin avatar Aug 14 '24 22:08 illsilin