composable_kernel
composable_kernel copied to clipboard
@bghimireamd [Informative]
@bghimireamd [Informative]
Had to rename MIOpen's #define ENV to #define MIOPEN_ENV because it was having name collision with recent introduction of CK's macro with same name #define ENV
Thanks for fixing the problem.
We do not export macro as a part of our public API and therefore it is OK to define whatever we want.
If CK exports its own macro (ENV
) in its public API, then it is CK who must take care about possible collisions with their users, for example by adding and unique prefix (like CK_
or COMPOSABLE_KERNELS_
). Or, better, they should avoid exporting macros in their API.
I'll take care about this.
Originally posted by @atamazov in https://github.com/ROCm/MIOpen/issues/2961#issuecomment-2117552920