composable_kernel icon indicating copy to clipboard operation
composable_kernel copied to clipboard

blockwise_gemm_xdlops.hpp uses non-member function with `.` operator

Open yxsamliu opened this issue 9 months ago • 0 comments

A recent clang change (https://github.com/llvm/llvm-project/pull/90152) revealed an issue in develop branch of composable_kernel:

https://github.com/ROCm/composable_kernel/blob/08d51d9bc4ec275fce3ad0a01a08ab1fd45636bc/include/ck/tensor_operation/gpu/block/blockwise_gemm_xdlops.hpp#L799

composable_kernel/include/ck/tensor_operation/gpu/block/blockwise_gemm_xdlops.hpp:799:32: error: no member named 'a_origin' in 'BlockwiseGemmXdlops_v2<BlockSize, FloatAB, FloatAcc, ATileDesc, BTileDesc, AMmaTileDesc, BMmaTileDesc, MPerBlock, NPerBlock, KPerBlock, MPerXDL, NPerXDL, MRepeat, NRepeat, KPack, TransposeC, AMmaKStride, BMmaKStride>'
  799 |         : a_thread_copy_(other.a_origin), b_thread_copy_(other.b_origin)
       |                          ~~~~~ ^
composable_kernel/include/ck/tensor_operation/gpu/block/blockwise_gemm_xdlops.hpp:799:64: error: no member named 'b_origin' in 'BlockwiseGemmXdlops_v2<BlockSize, FloatAB, FloatAcc, ATileDesc, BTileDesc, AMmaTileDesc, BMmaTileDesc, MPerBlock, NPerBlock, KPerBlock, MPerXDL, NPerXDL, MRepeat, NRepeat, KPack, TransposeC, AMmaKStride, BMmaKStride>'
   799 |         : a_thread_copy_(other.a_origin), b_thread_copy_(other.b_origin)
       |                                                          ~~~~~ ^

a_origin and b_origin are not members of BlockwiseGemmXdlops_v2.

yxsamliu avatar May 03 '24 18:05 yxsamliu