MIOpen icon indicating copy to clipboard operation
MIOpen copied to clipboard
verified publisher icon ROCmSoftwarePlatform

Update Conv3DTestCase to use structs

Open BrianHarrisonAMD opened this issue 1 year ago • 1 comments

This change is based off the bharriso/conv-bias-res-add-active-pattern-and-executor branch. These changes will address this feedback.

Changes:

  • Add Size3D struct for Conv3DtestCase
  • Swap img, filter, padding, stride, and dilation to use Size3D
  • Update testcases to follow the updated format & ordering (had to move some things around to make it consistent & correct)

BrianHarrisonAMD avatar Jul 26 '24 22:07 BrianHarrisonAMD

Waiting on PR #3161 to be merged first since this is branched off those changes.

BrianHarrisonAMD avatar Aug 01 '24 14:08 BrianHarrisonAMD

@BrianHarrisonAMD could you resolve the conflicted files above? When CI passes again we can merge this one.

junliume avatar Aug 07 '24 17:08 junliume

@BrianHarrisonAMD could you resolve the conflicted files above? When CI passes again we can merge this one.

Will do!

BrianHarrisonAMD avatar Aug 07 '24 17:08 BrianHarrisonAMD

Updated, and just waiting on CI now.

BrianHarrisonAMD avatar Aug 07 '24 20:08 BrianHarrisonAMD

@junliume There was a clean CI pass, and should be up to date. I pulled again since it was out of date, but it appears to be a clean merge without any overlap.

Should be good to merge whenever.

BrianHarrisonAMD avatar Aug 09 '24 18:08 BrianHarrisonAMD