MIOpen icon indicating copy to clipboard operation
MIOpen copied to clipboard

Tests use MIOpen internal APIs

Open xuantengh opened this issue 1 year ago • 0 comments

Hi developers,

MIOpen tests directly leverage internal APIs (e.g., miopen::ActivationDescriptor) rather than public APIs miopenCreateActivationDescriptor to implement the functionalities. This makes the shared library libMIOpen.so has to expose many unnecessary symbols.

Currently MIOpen uses the version script to control the symbol visibility, while other ROCm libraries like rocBLAS or rocSPARSE hide all internal symbols by default as their tests only use public APIs.

Distributions like Debian will maintain a symbol file for library binary compatibility between packages, hence the internal API usage in tests makes it hard to provide a clean symbol list with only public APIs.

xuantengh avatar Jul 02 '24 10:07 xuantengh