MIOpen icon indicating copy to clipboard operation
MIOpen copied to clipboard

Published 20 hours ago • verified publisher icon ROCmSoftwarePlatform

Resolve post-merge review comments of PR #2320

Open atamazov opened this issue 1 year ago • 5 comments

  • https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_high https://github.com/ROCmSoftwarePlatform/MIOpen/labels/request_for_comments Finally decide how to enable experimental API features
    • [ ] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1316419544
  • https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_blocker Let's enable and properly test the experimental feature everywhere.
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1326549529
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327664870
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327665023
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327667003
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327674330
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327674436
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327676122
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327678271
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327798211
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327798755
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327801851
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327817140
  • https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_normal Easy to resolve:
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1316416030
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327669307
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327670354
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327670537
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327670975
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327677582
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327678976
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327685024
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327691191
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327698204
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327705557
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327793095
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327794557
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327795549
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327796740
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327804335
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327817642
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1316412582
  • https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_normal May require more work/discussions:
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327687734
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327689633
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327697366
    • [x] https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2320#discussion_r1327790732

[Attribution] @junliume @JehandadKhan

  • https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_blocker
  • https://github.com/ROCmSoftwarePlatform/MIOpen/labels/IMPACTS_API
  • https://github.com/ROCmSoftwarePlatform/MIOpen/labels/quality
  • https://github.com/ROCmSoftwarePlatform/MIOpen/labels/testing
  • Proposed assignees:
    • @seungmanhan
    • @JehandadKhan (only for the 1st item)

atamazov avatar Sep 20 '23 18:09 atamazov

@junliume No progress for a month

atamazov avatar Oct 31 '23 18:10 atamazov

Ping @seungmanhan and also from Slack

junliume avatar Oct 31 '23 20:10 junliume

I was proceeding through PR(https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2481). Can I check it once it is completed?

seungmanhan avatar Nov 01 '23 04:11 seungmanhan

@seungmanhan Thanks! One detail: next time, let's put checkmarks after the resolving PR is merged in.

atamazov avatar Nov 01 '23 12:11 atamazov

@JehandadKhan @seungmanhan Is the last task on this ticket completed? Thanks!

ppanchad-amd avatar Apr 23 '24 19:04 ppanchad-amd